Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meson.build deprecations up to 0.56.0 #172

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix meson.build deprecations up to 0.56.0 #172

merged 1 commit into from
Oct 2, 2023

Conversation

rcalixte
Copy link
Member

@rcalixte rcalixte commented Sep 25, 2023

@Fantu
Copy link
Contributor

Fantu commented Sep 25, 2023

hi, in this and probably others PR is missed meson required version (meson_version: '>=0.56.0' in meson.build)
in packaging can be not increased as latest debian stable and ubuntu LTS (for mint) that have major version but I think at least version in meson.build is useful for other distro older or users that want do backports

@rcalixte
Copy link
Member Author

hi, in this and probably others PR is missed meson required version (meson_version: '>=0.56.0' in meson.build) in packaging can be not increased as latest debian stable and ubuntu LTS (for mint) that have major version but I think at least version in meson.build is useful for other distro older or users that want do backports

Meson 0.56.0 was released in October 2020:

  • Ubuntu 22.04 shipped with 0.61.2.
  • Debian 11 shipped with 0.56.2 and has 1.0.0 available via backports.
  • Debian 10 has 0.56.1 available via backports as well.

Are there any older distributions that need to backport beyond those bases?

@Fantu
Copy link
Contributor

Fantu commented Sep 25, 2023

there isn't only debian and ubuntu, I suggest to add meson_version: '>=0.56.0' in meson.build anyway so any user that try to build with older meson understands that's the problem

@rcalixte
Copy link
Member Author

there isn't only debian and ubuntu, I suggest to add meson_version: '>=0.56.0' in meson.build anyway so any user that try to build with older meson understands that's the problem

Ah, I think I misunderstood you initially. Done. I also checked the others. Thanks for the review!

@mtwebster mtwebster merged commit 5df5051 into linuxmint:master Oct 2, 2023
3 checks passed
@rcalixte rcalixte deleted the meson_deprecations branch October 2, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants