Duplicate only current line when cursor is at the end of the line #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue linuxmint#643. When cursor is at the end of the line, old version would duplicate two lines: The line where the cursor is, and the line following it. This happened because the buffer that is being copied would include both lines and the newline separating them. This fix checks if there are multiple lines in the current buffer, and if so, moves buffers end iterator to the newline character, so that only the line where cursor is located is duplicated.
linewelder
suggested changes
Oct 10, 2024
Comment on lines
783
to
+793
| gtk_text_iter_forward_to_line_end (&end); | ||
|
|
||
| if (gtk_text_buffer_get_line_count (buffer) > 1) | ||
| { | ||
| gtk_text_iter_assign (&end, &start); | ||
| while (gtk_text_iter_get_char (&end) != '\n' && | ||
| !gtk_text_iter_is_end (&end)) | ||
| { | ||
| gtk_text_iter_forward_char (&end); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| gtk_text_iter_forward_to_line_end (&end); | |
| if (gtk_text_buffer_get_line_count (buffer) > 1) | |
| { | |
| gtk_text_iter_assign (&end, &start); | |
| while (gtk_text_iter_get_char (&end) != '\n' && | |
| !gtk_text_iter_is_end (&end)) | |
| { | |
| gtk_text_iter_forward_char (&end); | |
| } | |
| } | |
| if (gtk_text_iter_get_char (&end) != '\n' && | |
| gtk_text_iter_get_char (&end) != '\r') | |
| { | |
| gtk_text_iter_forward_to_line_end (&end); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #643. When cursor is at the end of the line, old version would duplicate two lines: The line where the cursor is, and the line following it. This happened because the buffer that is being copied would include both lines and the newline separating them. This fix checks if there are multiple lines in the current buffer, and if so, moves buffers end iterator to the newline character, so that only the line where cursor is located is duplicated.