Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to noble, add encryption support (master) #84

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thespad
Copy link
Member

@thespad thespad commented Aug 29, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This will fail until 2.0.9 hits stable.

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team August 29, 2024 16:06
@thespad thespad self-assigned this Aug 29, 2024
@thespad thespad marked this pull request as draft August 29, 2024 16:06
@kenkendk
Copy link

kenkendk commented Sep 4, 2024

FYI: Duplicati removed the auto-assigned settings encryption key in v2.0.9.106, so only version 2.0.9.105 is using a system-derived encryption key.
The change was rolled back after we discovered the device key was not based on sufficiently random data (in many case, it was based on an empty string).

The changes in this PR are thus not required for Duplicati 2.0.9.106+ but increases security by specifying a settings encryption key.

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale exempt
Projects
Status: PRs Ready For Team Review
Development

Successfully merging this pull request may close these issues.

3 participants