You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have read the contributing guideline and understand that I have made the correct modifications
Description:
This PR replaces hardcoded paths for directory creation/ownership with paths parsed from settings.json. If paths cannot be found in the file, defaults are used.
For standard installations, this change has no effect. In the case that a user sets a custom path for download-dir and/or incomplete-dir in settings.json, the run script will mkdir/lsiown the custom directories instead of the defaults.
Benefits of this PR and context:
Currently, even if a user changes the path(s) of download-dir/incomplete-dir in settings.json, the run script will still mkdir/lsiown the default directories (/downloads/complete & /downloads/incomplete) every time the container starts. Although these unused directories don't pose any serious issue, they can be a nuisance when navigating with autocomplete in the command line.
- prevents automatic creation of unused directories
- if `settings.json` contains `download-dir`/`incomplete-dir` properties, read the values and use them for `mkdir`/`lsiown` commands on container start
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cartfisk
force-pushed
the
no-dir-create-for-custom-path
branch
from
Description:
This PR replaces hardcoded paths for directory creation/ownership with paths parsed from
settings.json. If paths cannot be found in the file, defaults are used.For standard installations, this change has no effect. In the case that a user sets a custom path for
download-dirand/orincomplete-dirinsettings.json, the run script willmkdir/lsiownthe custom directories instead of the defaults.Benefits of this PR and context:
Currently, even if a user changes the path(s) of
download-dir/incomplete-dirinsettings.json, the run script will stillmkdir/lsiownthe default directories (/downloads/complete&/downloads/incomplete) every time the container starts. Although these unused directories don't pose any serious issue, they can be a nuisance when navigating with autocomplete in the command line.How Has This Been Tested?
Ran jenkins-builder.
Source / References:
#265
#256
#266