Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Run with all QGIS 3 LTR images #114

Merged
merged 3 commits into from
May 21, 2021
Merged

tests: Run with all QGIS 3 LTR images #114

merged 3 commits into from
May 21, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented May 21, 2021 •
edited
Loading

Closes #96, #106.

@l0b0 l0b0 requested review from dwsilk, billgeo and SPlanzer May 21, 2021 01:40
@l0b0 l0b0 self-assigned this May 21, 2021
@l0b0 l0b0 marked this pull request as draft May 21, 2021 01:43
@l0b0 l0b0 force-pushed the tests/run-with-all-qgis-3-ltr-images branch from b607d27 to 96c14fd Compare May 21, 2021 02:05
@l0b0 l0b0 marked this pull request as ready for review May 21, 2021 02:05
l0b0 added 3 commits May 21, 2021 15:01
@l0b0
docs: Clarify synopsis
87c3e70
@l0b0
tests: Run with all QGIS 3 LTR images
c713831
@l0b0
tests: Run all tests to the end even if one fails
037e8c3 
Gives more useful information in case the code is incompatible with only
some versions of QGIS.
@l0b0 l0b0 force-pushed the tests/run-with-all-qgis-3-ltr-images branch from ca4d228 to 037e8c3 Compare May 21, 2021 03:03
billgeo
billgeo approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@billgeo billgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, runs on CI fine (although tests seems to intermittently fail). I tried a couple of versions locally and they also ran okay.

@l0b0
Copy link
Contributor Author

l0b0 commented May 21, 2021 •
edited
Loading

LGTM, runs on CI fine (although tests seems to intermittently fail). I tried a couple of versions locally and they also ran okay.

Yeah, I've filed an issue with some details. This sort of thing is pretty easy to fix. Of course, now that we're running with four different versions we're four times more likely to fail any intermittent tests.

@l0b0 l0b0 merged commit b214def into main May 21, 2021
@l0b0 l0b0 deleted the tests/run-with-all-qgis-3-ltr-images branch May 21, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billgeo billgeo billgeo approved these changes

@dwsilk dwsilk Awaiting requested review from dwsilk

@SPlanzer SPlanzer Awaiting requested review from SPlanzer

Assignees

@l0b0 l0b0

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test on older versions of QGIS 3
2 participants
@l0b0 @billgeo