Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ DAT-19435: add provenance: false #175

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sayaliM0412
Copy link
Contributor

@sayaliM0412 sayaliM0412 commented Jan 24, 2025

  • This pull request includes changes to the .github/workflows/deploy-extension-to-marketplace.yml file to disable the generation of provenance attestation in two job steps.
  • AWS Marketplace listing scanners currently do not support images with attestation layers. They are working on a fix to ignore these layers. In the meanwhile we need to pass provenance:false.
  • What is provenance attestation: In the context of Docker builds and container supply chains, provenance attestations refer to metadata that describes how, when, and by whom a container image or artifact was created. Read more about it here: https://docs.docker.com/build/metadata/attestations/slsa-provenance/

Changes to deployment workflow:

  • Modified the condition for the build job to correctly compare the dry_run input as a string.
  • Added the provenance: false configuration to disable the generation of provenance attestation in two places within the build job.

@StevenMassaro
Copy link
Contributor

AWS Marketplace listing scanners currently do not support images with attestation layers.

This doesn't make sense to me. We have previously published docker images built with this workflow to the AWS marketplace. Is this a new change from AWS?

@sayaliM0412
Copy link
Contributor Author

AWS Marketplace listing scanners currently do not support images with attestation layers.

This doesn't make sense to me. We have previously published docker images built with this workflow to the AWS marketplace. Is this a new change from AWS?

I have already reached out them with the same question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants