Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #267

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix build #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af1f8d5
Fix build
filipelautert Dec 13, 2024
236f42f
fix: use driver version from pom
filipelautert Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,23 @@ jobs:
steps:
- run: true

setup:
runs-on: ubuntu-latest
needs: authorize
outputs:
driver_version: ${{ steps.get-driver_version.outputs.driver_version }}

steps:
- uses: actions/checkout@v4

- name: Extract driver version to parameter
id: get-driver_version
run: |
driver_version=$(mvn org.apache.maven.plugins:maven-help-plugin:3.2.0:evaluate -Dexpression=redshift.driver.version -q -DforceStdout)
echo "driver_version=${driver_version}" >> $GITHUB_OUTPUT



build-test:
needs: authorize
uses: liquibase/build-logic/.github/workflows/os-extension-test.yml@main
Expand All @@ -25,7 +42,7 @@ jobs:

prepare-database:
name: Clean and initialize database
needs: build
needs: [setup, build-test]
runs-on: ubuntu-latest
container:
image: liquibase/liquibase:latest
Expand All @@ -43,7 +60,7 @@ jobs:

# FIXME the redshift jar version should come from the pom.xml file
- name: Download AWS Redshift driver
run: wget https://s3.amazonaws.com/redshift-downloads/drivers/jdbc/2.1.0.14/redshift-jdbc42-2.1.0.14.jar
run: wget https://s3.amazonaws.com/redshift-downloads/drivers/jdbc/${{ needs.setup.outputs.driver_version }}/redshift-jdbc42-${{ needs.setup.outputs.driver_version }}.jar

- name: Add Redshift extension and driver to liquibase classpath
run: |
Expand Down
3 changes: 2 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<properties>
<liquibase.version>4.30.0</liquibase.version>
<jacoco.fileset.directory>target</jacoco.fileset.directory>
<redshift.driver.version>2.1.0.14</redshift.driver.version>
</properties>

<scm>
Expand All @@ -43,7 +44,7 @@
<dependency>
<groupId>com.amazon.redshift</groupId>
<artifactId>redshift-jdbc42</artifactId>
<version>2.1.0.31</version>
<version>${redshift.driver.version}</version>
</dependency>
<dependency>
<groupId>org.liquibase</groupId>
Expand Down
Loading