fix: include imports so tests run independently #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you were to comment out the test that uses `instanceof`, the rest of the tests would fail due to the import being tree shaken by typescript. without the import, the code that puts MyElement into `customElements` won't ever get ran. this import ensures that the import stays no matter what kind of test you write, thus ensuring that the `customElements` piece is ran. credit to @Westbrook for coming up with the solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you were to comment out the test that uses
instanceof, the rest ofthe tests would fail due to the import being tree shaken by typescript.
without the import, the code that puts MyElement into
customElementswon't ever get ran.
this import ensures that the import stays no matter what kind of test
you write, thus ensuring that the
customElementspiece is ran.credit to @Westbrook for coming up with the solution