Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify "types" in tsconfig.json #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Specify "types" in tsconfig.json #89

wants to merge 1 commit into from

Conversation

Retsam
Copy link

@Retsam Retsam commented Mar 20, 2023

By default TS will pull in any global modifying types that it finds - by specifying a types field it'll only pull in specific ones - which is usually a very small list of packages.

This fixes a current issue where @types/estree conflicts with @types/eslint causes npm run build to fail. But neither set of typings is needed so specifying "types" avoids the issue.

By default TS will pull in any global modifying types that it finds - by specifying a types field it'll only pull in specific ones - which is usually a very small list of packages.

This fixes a current issue where @types/estree conflicts with @types/eslint causes `npm run build` to fail.  But neither set of typings is needed so specifying "types" avoids the issue.
@google-cla
Copy link

google-cla bot commented Mar 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@7yl4r 7yl4r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the ts2724: "no exported member" errors I was seeing when trying to build the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants