Decorator Roadmap #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
requested review from
graynorton,
kevinpschaaf and
sorvell
as code owners
rictic
approved these changes
May 25, 2023
|
Looks great! A few comments, the only serious one is about |
AndrewJakubowicz
approved these changes
Aug 17, 2023
justinfagnani
commented
Aug 22, 2023
augustjk
reviewed
Oct 26, 2023
augustjk
reviewed
Oct 26, 2023
Co-authored-by: Augustine Kim <[email protected]>
augustjk
approved these changes
Oct 27, 2023
justinfagnani
commented
Oct 27, 2023
|
Thank you @justinfagnani! Applied your changes. Also ignore the failing CLA. It is not able to figure out personal GitHub emails. |
Co-authored-by: Justin Fagnani <[email protected]>
augustjk
force-pushed
the
decorator-roadmap
branch
from
6867d39
to
dd5d4e6
Compare
|
Fixed CLA issue by amending commit and force pushing |
justinfagnani
commented
Oct 28, 2023
|
LGTM on allo changes! |
Co-authored-by: Justin Fagnani <[email protected]>
augustjk
force-pushed
the
decorator-roadmap
branch
from
3fc6dbf
to
30ee537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.