Fix and add patterns in language_java, language_kotlin and language_groovy.
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Yeah, but the regex in the PR is different. |
|
The one in the PR is the the old one. |
PerilousBooklet
changed the title
language_java constants pattern.language_java, language_kotlin and language_groovy.
Guldoman
reviewed
Jan 7, 2025
Comment on lines
+16
to
+18
| { pattern = "'\\x%x?%x?%x?%x'", type = "string" }, -- character hexadecimal escape sequence | ||
| { pattern = "'\\u%x%x%x%x'", type = "string" }, -- character unicode escape sequence | ||
| { pattern = "'\\?.'", type = "string" }, -- character literal |
There was a problem hiding this comment.
Should those go above the preceding line?
There was a problem hiding this comment.
Honestly I don't even know what that is.
I didn't write it.
I probably just commented it a few months ago or something like that.
|
Sure, I'll replace the |
Yeah, we might as well. |
…for Java and constants pattern for Java and Kotlin.
…x patterns still using double apices.
…eference inside a method's ()
|
Ok, now it should be much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test this PR with:
git clone https://github.com/PerilousBooklet/lite-xl-plugins.gitgit fetch && git checkout PR_java_constantslpm run --ephemeral ./ language_java