Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation in probes modal and fixed the type issue while probe creation #2738

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

amityt
Copy link
Contributor

@amityt amityt commented Apr 22, 2021

Signed-off-by: Amit Kumar Das [email protected]

Proposed changes

This PR adds:

  • Fixed validation of names and other paramaters in probes modal
  • Fixed the type issue in Probes Creation
  • Fixed an issue where chaos engine was getting saved after clicking the close button of vertical stepper. The complete data will be saved after clicking the finish button of vertical stepper.

Reference: Scheduling/Browsing/Visualisation user-flow issues

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@amityt amityt requested review from S-ayanide and Jonsy13 April 22, 2021 13:02
@amityt amityt self-assigned this Apr 22, 2021
@codesniffy codesniffy bot added the size/L label Apr 22, 2021
@amityt amityt changed the title Added validation in probes modal and fixed the type issue while probe creation [WIP] Added validation in probes modal and fixed the type issue while probe creation Apr 26, 2021
@codesniffy codesniffy bot added size/XL and removed size/L labels Apr 26, 2021
@amityt amityt changed the title [WIP] Added validation in probes modal and fixed the type issue while probe creation Added validation in probes modal and fixed the type issue while probe creation Apr 26, 2021
@S-ayanide S-ayanide merged commit 06320ee into litmuschaos:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants