-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: documentation for the Chaoscenter Authentication REST API #5012
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
d18354d
to
a121b20
Compare
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
c.JSON(http.StatusOK, gin.H{ | ||
"message": "Successful", | ||
}) | ||
c.JSON(http.StatusOK, response.MessageResponse{Message: "Successful"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @namkyu1999, It’s really a trivial point but I think it's better to unify the capitalization.
For example, other MessageResponses are using 'successful' but here is 'Successful'. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand your opinion. However, in this PR, I want to ensure that the return values remain unchanged.
LGTM |
@namkyu1999 could you please check the unit test, one of them is failing. |
Signed-off-by: namkyu1999 <[email protected]>
done @Saranya-jena |
Proposed changes
This PR updates authentication api document from v2.0.0 to v3.14.0
Changes contain...
Demo Links is here: https://namkyu-park99.github.io/litmus/auth/v3.14.0/api.html
Resolves #4771 litmuschaos/litmus-docs#296
ref #4910
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: