Merge pull request #15 from little-angry-clouds/fix/send_errors_stderr

little-angry-clouds · Jun 27, 2020 · e0adfb4 · e0adfb4
2 parents 1a6be61 + e3b15ea
commit e0adfb4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/cmd/helmenv/README.md b/cmd/helmenv/README.md
@@ -1,4 +1,4 @@
-![Static Tests](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Generic%20tests/badge.svg) ![Int test Linux](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20test%20in%20Linux/badge.svg) ![Int test MacOS](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Integrarion%20test%20in%20MacOS/badge.svg) ![Int test Windows](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20test%20in%20Windows/badge.svg)
+![Static Tests](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Generic%20tests/badge.svg) ![Int Test Linux](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20Test%20Linux/badge.svg) ![Int Test MacOS](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20Test%20MacOS/badge.svg) ![Int Test Windows](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20Test%20Windows/badge.svg)
 
 # helmenv
 [Helm](https://helm.sh/) version manager inspired by

diff --git a/cmd/kbenv/README.md b/cmd/kbenv/README.md
@@ -1,4 +1,4 @@
-![Static Tests](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Generic%20tests/badge.svg) ![Integration Test in Linux](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Integration%20test%20in%20Linux/badge.svg) ![Integrarion Test in MacOS](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Integrarion%20test%20in%20MacOS/badge.svg) ![Integration Test in Windows](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Integration%20test%20in%20Windows/badge.svg)
+![Static Tests](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Generic%20tests/badge.svg) ![Int Test Linux](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20Test%20Linux/badge.svg) ![Int Test MacOS](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20Test%20MacOS/badge.svg) ![Int Test Windows](https://github.com/little-angry-clouds/kubernetes-binaries-managers/workflows/Int%20Test%20Windows/badge.svg)
 
 # kbenv
 [Kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) version

diff --git a/internal/helpers/helpers.go b/internal/helpers/helpers.go
@@ -15,7 +15,7 @@ import (
 func CheckGenericError(err error) {
 	if err != nil {
 		message := fmt.Sprintf("An error was detected, exiting: %s", err)
-		fmt.Println(message)
+		fmt.Fprintf(os.Stderr, "%s\n", message)
 		os.Exit(1) // nolint:gomnd
 	}
 }
@@ -37,7 +37,7 @@ func CheckHTTPError(resp *http.Response) {
 			message = string(body)
 		}
 
-		fmt.Println("An error detected getting all versions: " + message)
+		fmt.Fprintf(os.Stderr, "An error detected getting all versions: %s", message)
 		os.Exit(1) // nolint:gomnd
 	}
 }

diff --git a/internal/wrapper/main.go b/internal/wrapper/main.go
@@ -75,10 +75,7 @@ func Wrapper(binName string) { // nolint: funlen
 			cmd.Stderr = os.Stderr
 			err = cmd.Run()
 
-			if err != nil {
-				fmt.Printf("%s\n", err)
-				os.Exit(1)
-			}
+			helpers.CheckGenericError(err)
 		}
 
 		finalVersion = version
@@ -95,6 +92,6 @@ func Wrapper(binName string) { // nolint: funlen
 	err = cmd.Run()
 
 	if err != nil {
-		fmt.Printf("%s\n", err)
+		fmt.Fprintf(os.Stderr, "%s\n", err)
 	}
 }