Skip to content

Commit

Permalink
Add unit tests for build history.
Browse files Browse the repository at this point in the history
  • Loading branch information
tamalsaha committed Jan 25, 2017
1 parent 93d208b commit 6a4b536
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
4 changes: 4 additions & 0 deletions _tests/build_history.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@



<table page-has-up="false" page-has-down="false" page-entry-newest="-9223372036854775805" page-entry-oldest="-9223372036854775807" class="pane hasPageData"><tr page-entry-id="-9223372036854775805" class="build-row single-line"><td class="build-row-cell"><div class="pane build-name"><div class="build-icon"><a href="/jenkins/job/j1/3/console" class="build-status-link"><img src="/jenkins/images/16x16/blue.png" alt="Success &gt; Console Output" tooltip="Success &gt; Console Output" style="width: 16px; height: 16px; " class="icon-blue icon-sm" /></a></div><a update-parent-class=".build-row" href="/jenkins/job/j1/3/" class="tip model-link inside build-link display-name">#3</a></div><div time="1484327939346" class="pane build-details"><a update-parent-class=".build-row" href="/jenkins/job/j1/3/" class="tip model-link inside build-link">Jan 13, 2017 9:18 AM</a></div><div class="pane build-controls"><div class="middle-align build-badge"></div></div><div class="left-bar"></div></td></tr><tr page-entry-id="-9223372036854775806" class="build-row single-line"><td class="build-row-cell"><div class="pane build-name"><div class="build-icon"><a href="/jenkins/job/j1/2/console" class="build-status-link"><img src="/jenkins/images/16x16/blue.png" alt="Success &gt; Console Output" tooltip="Success &gt; Console Output" style="width: 16px; height: 16px; " class="icon-blue icon-sm" /></a></div><a update-parent-class=".build-row" href="/jenkins/job/j1/2/" class="tip model-link inside build-link display-name">#2</a></div><div time="1484327935341" class="pane build-details"><a update-parent-class=".build-row" href="/jenkins/job/j1/2/" class="tip model-link inside build-link">Jan 13, 2017 9:18 AM</a></div><div class="pane build-controls"><div class="middle-align build-badge"></div></div><div class="left-bar"></div></td></tr><tr page-entry-id="-9223372036854775807" class="build-row single-line"><td class="build-row-cell"><div class="pane build-name"><div class="build-icon"><a href="/jenkins/job/j1/1/console" class="build-status-link"><img src="/jenkins/images/16x16/blue.png" alt="Success &gt; Console Output" tooltip="Success &gt; Console Output" style="width: 16px; height: 16px; " class="icon-blue icon-sm" /></a></div><a update-parent-class=".build-row" href="/jenkins/job/j1/1/" class="tip model-link inside build-link display-name">#1</a></div><div time="1484327924442" class="pane build-details"><a update-parent-class=".build-row" href="/jenkins/job/j1/1/" class="tip model-link inside build-link">Jan 13, 2017 9:18 AM</a></div><div class="pane build-controls"><div class="middle-align build-badge"></div></div><div class="left-bar"></div></td></tr></table>
10 changes: 10 additions & 0 deletions jenkins_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package gojenkins
import (
"io/ioutil"
"math/rand"
"os"
"testing"
"time"

Expand Down Expand Up @@ -71,6 +72,15 @@ func TestCreateBuilds(t *testing.T) {
}
}

func TestParseBuildHistory(t *testing.T) {
r, err := os.Open("_tests/build_history.txt")
if err != nil {
panic(err)
}
history := parseBuildHistory(r)
assert.True(t, len(history) == 3)
}

func TestCreateViews(t *testing.T) {
list_view, err := jenkins.CreateView("test_list_view", LIST_VIEW)
assert.Nil(t, err)
Expand Down
7 changes: 1 addition & 6 deletions job.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"net/url"
"path"
"strconv"
"strings"
)

type Job struct {
Expand Down Expand Up @@ -468,11 +467,7 @@ func (j *Job) Poll() (int, error) {
}

func (j *Job) History() ([]*history, error) {
endpoint := j.Raw.URL[strings.Index(j.Raw.URL, "/job"):]
endpoint = strings.TrimSuffix(endpoint, "/")
endpoint += "/buildHistory/ajax"

resp, err := j.Jenkins.Requester.Get(endpoint, nil, nil)
resp, err := j.Jenkins.Requester.Get(j.Base+"/buildHistory/ajax", nil, nil)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 6a4b536

Please sign in to comment.