Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): update .lokalise.json after pulling from Lokalise #684

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

zyf722
Copy link
Contributor

@zyf722 zyf722 commented Dec 11, 2024

What type of PR is this? (check all applicable)

  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • ♻️ Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert
  • 🌐 Internationalization / Translation

Description

Updated the workflow to add the step of generating latest .lokalise.json files for translated languages (languages other than en) after pulling from Lokalise.

Also updated related documentations with changes to i18n-lokalise-json and suggestion proposed here.

Related Tickets & Documents

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentations?

  • πŸ““ docs (./docs)
  • πŸ“• storybook (./storybook)
  • πŸ“œ README.md
  • πŸ™… no documentation needed

Copy link

netlify bot commented Dec 11, 2024

βœ… Deploy Preview for livecodes ready!

Name Link
πŸ”¨ Latest commit 52f9f31
πŸ” Latest deploy log https://app.netlify.com/sites/livecodes/deploys/6759bdeed5b75000083f0a2a
😎 Deploy Preview https://deploy-preview-684--livecodes.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hatemhosny hatemhosny merged commit 310cd77 into live-codes:develop Dec 11, 2024
13 checks passed
Copy link
Contributor

livecodes-ci bot commented Dec 11, 2024

i18n Actions

Source PR has been merged into the default branch.

Maintainers can comment .i18n-update-push to trigger the i18n update workflow and push the changes to Lokalise.

@hatemhosny
Copy link
Collaborator

Thanks a lot, @zyf722

@hatemhosny
Copy link
Collaborator

Should we push this?
#684 (comment)

@zyf722
Copy link
Contributor Author

zyf722 commented Dec 12, 2024

Should we push this?
#684 (comment)

No, since no source code is edited.

As long as dev-gui branch on Lokalise has been merged into masterafter merging the UI overhaul PR, everything should be in sync.

@hatemhosny
Copy link
Collaborator

No, since no source code is edited.

As long as dev-gui branch on Lokalise has been merged into masterafter merging the UI overhaul PR, everything should be in sync.

It was merged indeed.
Thank you πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants