Skip to content

Commit

Permalink
Ignore :export_info_string passed to Kino.JS.new/3 instead of raising
Browse files Browse the repository at this point in the history
  • Loading branch information
jonatanklosko committed Feb 26, 2025
1 parent 4fecd0c commit 9a318ae
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/kino/js.ex
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,9 @@ defmodule Kino.JS do
"""
@spec new(module(), term(), keyword()) :: t()
def new(module, data, opts \\ []) do
opts = Keyword.validate!(opts, [:export])
# TODO: remove :export_info_string on v1.0, for now we just ignore
# it in case a library passes both export options.
opts = Keyword.validate!(opts, [:export, :export_info_string])
export = opts[:export]

ref = Kino.Output.random_ref()
Expand Down

0 comments on commit 9a318ae

Please sign in to comment.