Skip to content

Commit

Permalink
Ignore :export_key passed to Kino.JS.new/3 instead of raising (#495)
Browse files Browse the repository at this point in the history
  • Loading branch information
deadego authored Feb 27, 2025
1 parent 3fad45b commit f46e032
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/kino/js.ex
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,9 @@ defmodule Kino.JS do
"""
@spec new(module(), term(), keyword()) :: t()
def new(module, data, opts \\ []) do
# TODO: remove :export_info_string on v1.0, for now we just ignore
# TODO: remove :export_info_string, :export_key on v1.0, for now we just ignore
# it in case a library passes both export options.
opts = Keyword.validate!(opts, [:export, :export_info_string])
opts = Keyword.validate!(opts, [:export, :export_info_string, :export_key])
export = opts[:export]

ref = Kino.Output.random_ref()
Expand Down

0 comments on commit f46e032

Please sign in to comment.