Support SSL for Postgres/MySQL and accept a custom CA certificates file #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
changed the title
josevalim
reviewed
Jun 12, 2024
| [cacerts: quote(do: :public_key.cacerts_get())] | ||
| end | ||
|
|
||
| [ssl: true, ssl_opts: ssl_opts] |
There was a problem hiding this comment.
Gah, we should update TDS. @wojtekmach? :P
josevalim
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud providers may require a custom CA certificates file for SSL to work. When the SSL switch is toggled, we now show an additional field for CA certificates:
When left empty, we use he OS defaults via
:public_key.cacerts_get().Sidnote: even though we had code to add SSL options for Postgres and MySQL, there was no switch in the UI, so effectively it was only supported for SQLServer.