Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List module definitions in the sections side panel #2760

Merged
merged 16 commits into from
Aug 23, 2024
Merged

List module definitions in the sections side panel #2760

merged 16 commits into from
Aug 23, 2024

Conversation

aleDsz
Copy link
Member

@aleDsz aleDsz commented Aug 22, 2024 •
edited
Loading

Kooha-2024-08-23-18-01-10.mp4

@aleDsz aleDsz self-assigned this Aug 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

Uffizzi Preview deployment-55475 was deleted.

@jonatanklosko jonatanklosko changed the title Show which modules each section defines under the Sections pane in the sidebar List module definitions in the sections side panel Aug 23, 2024
josevalim
josevalim approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se no longer need to change the intellisense module since we won’t need to pass byte code, and then we can ship it!!!

@aleDsz aleDsz merged commit ad0db18 into main Aug 23, 2024
7 checks passed
@jonatanklosko jonatanklosko deleted the ale-sections-modules branch August 24, 2024 05:16
jonatanklosko pushed a commit that referenced this pull request Aug 26, 2024
@aleDsz @jonatanklosko
List module definitions in the sections side panel (#2760)
f009702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

@jonatanklosko jonatanklosko jonatanklosko approved these changes

@wojtekmach wojtekmach Awaiting requested review from wojtekmach

Assignees

@aleDsz aleDsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleDsz @josevalim @jonatanklosko