Add custom view option to hide code #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2798.
I didn't add the show/uncollapse button, because but I think it's fine. In the custom view mode we don't show cell actions, so it's also the case for Markdown. If someone wants to edit the code they can hit i/Enter. The primary reason is technical; we handle the views with CSS rules and I want to avoid rendering extra hidden content for collapsed cell that would rarely be shown, so instead the whole placeholder is done via CSS.
I don't like how complex the CSS is to handle all the cases, but it is what it is. I have a few ideas to simplify the rules overall, but I will try these out separately.