FIX: pricePerBroadcaster JSON file line breaks parsing bug #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2914 +/- ##
===================================================
- Coverage 56.54162% 56.52599% -0.01563%
===================================================
Files 89 89
Lines 19460 19453 -7
===================================================
- Hits 11003 10996 -7
Misses 7849 7849
Partials 608 608
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Rick Staa <[email protected]>
rickstaa
reviewed
Dec 7, 2023
mjh1
approved these changes
Dec 8, 2023
Merged
eliteprox
pushed a commit
to eliteprox/go-livepeer
that referenced
this pull request
Feb 21, 2024
…2914) * FIX: pricePerBroadcaster JSON file line breaks parsing bug --------- Co-authored-by: Rick Staa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! Based on #2913 from @rickstaa !!
What does this pull request do? Explain your changes. (required)
The current go-livepeer livepeer binary does not correctly parse pricePerBroadcaster files if they contain line breaks.
This pull request ensures that the pricePerBroadcaster flag also works with JSON files that contain line breaks as is often done to improve readability.
As far as I could tell, the previous iteration was done as a way to make sure single line + newline files that contained e.g a password parsed correctly and didn't bring in the newline.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Fixes #2912
Checklist:
makeruns successfully./test.shpass