Fix ValueRedeemed stat #2915
Closed
Fix ValueRedeemed stat #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stronk-dev any thoughts on making this backwards compatible if people have built tooling off the back of the old naming? It seems like the previous method was being called in the code |
|
Ah you're right, it does get called, so then this whole PR is moot. I thought it was broken (due to an error in my query) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
There is a unused prometheus metric to track the value of winning tickets redeemed. This PR modifies the naming to be inline with other prometheus metrics and makes sure it gets updated
How did you test each of these updates (required)
not yet, any takers?