Enhance aiRunnerImage flag #3284
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upporting JSON string
…image-flag-support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3284 +/- ##
===================================================
- Coverage 33.75539% 33.75271% -0.00268%
===================================================
Files 141 141
Lines 37357 37357
===================================================
- Hits 12610 12609 -1
- Misses 24027 24028 +1
Partials 720 720
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
rickstaa
reviewed
Nov 30, 2024
cmd/livepeer/livepeer.go
Outdated
| @@ -160,7 +160,7 @@ func parseLivepeerConfig() starter.LivepeerConfig { | |||
| cfg.AIWorker = flag.Bool("aiWorker", *cfg.AIWorker, "Set to true to run an AI worker") | |||
| cfg.AIModels = flag.String("aiModels", *cfg.AIModels, "Set models (pipeline:model_id) for AI worker to load upon initialization") | |||
| cfg.AIModelsDir = flag.String("aiModelsDir", *cfg.AIModelsDir, "Set directory where AI model weights are stored") | |||
| cfg.AIRunnerImage = flag.String("aiRunnerImage", *cfg.AIRunnerImage, "Set the docker image for the AI runner: Example - livepeer/ai-runner:0.0.1") | |||
| cfg.AIRunnerImage = flag.String("aiRunnerImage", *cfg.AIRunnerImage, "Set the docker image for the AI runner: Example - livepeer/ai-runner:0.0.1 . You can also provide a JSON string to map specific pipeline names to custom images, allowing for pipeline-specific image overrides: Example - '{\"segment-anything-2\": \"livepeer/ai-runner:segment-anything-2-v1.0\", \"another-pipeline\": \"livepeer/ai-runner:another-pipeline-v2.0\"}'") | |||
There was a problem hiding this comment.
Suggested change
| cfg.AIRunnerImage = flag.String("aiRunnerImage", *cfg.AIRunnerImage, "Set the docker image for the AI runner: Example - livepeer/ai-runner:0.0.1 . You can also provide a JSON string to map specific pipeline names to custom images, allowing for pipeline-specific image overrides: Example - '{\"segment-anything-2\": \"livepeer/ai-runner:segment-anything-2-v1.0\", \"another-pipeline\": \"livepeer/ai-runner:another-pipeline-v2.0\"}'") | |
| cfg.AIRunnerImage = flag.String("aiRunnerImage", *cfg.AIRunnerImage, `Set the docker image for the AI runner: Example - livepeer/ai-runner:0.0.1 . You can also provide a JSON string to map specific pipeline names to custom images, allowing for pipeline-specific image overrides: Example - '{"segment-anything-2": "livepeer/ai-runner:segment-anything-2-v1.0", "another-pipeline": "livepeer/ai-runner:another-pipeline-v2.0"}'`) |
There was a problem hiding this comment.
@RUFFY-369 looks good! However, maybe we can use raw string literals to cleanup the code a bit?
There was a problem hiding this comment.
@rickstaa Just pushed the commit for the suggestion. Thanks!
|
@rickstaa @RUFFY-369 Are we waiting on anything to merge this PR? |
@ad-astra-video In my opinion, I don't think so. We can have @rickstaa 's thought if he has something in mind before this merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Towards closing 'livepeer/bounties/#69
This PR improves the
aiRunnerImageflag to accept both string and JSON string inputs by adding the doc. Functionality is on theai-workerside.Usage:
aiRunnerImage="{'segment-anything-2': 'livepeer/ai-runner:segment-anything-2-v1.0'}"Specific updates (required)
How did you test each of these updates (required)
Test was performed by starting go-livepeer as aiWorker with
aiRunnerImage="{'segment-anything-2': 'livepeer/ai-runner:segment-anything-2-v1.0'}"and verified launch version.Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpasscc @rickstaa