Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: ai authWebhook: send gatewayHost to auth webhook #3320

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

gioelecerati
Copy link
Member

@gioelecerati gioelecerati commented Dec 16, 2024

What does this pull request do? Explain your changes. (required)

Specific updates (required)

  • Set up a gatewayHost flag and add it to livepeernode
  • Send the gatewayHost back to the live ai auth webhook

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.91978%. Comparing base (df2ed58) to head (288f07e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/livepeer/starter/starter.go 0.00000% 5 Missing ⚠️
server/ai_mediaserver.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3320         +/-   ##
===================================================
- Coverage   33.94992%   33.91978%   -0.03014%     
===================================================
  Files            141         141                 
  Lines          37140       37173         +33     
===================================================
  Hits           12609       12609                 
- Misses         23811       23844         +33     
  Partials         720         720                 
Files with missing lines Coverage Δ
cmd/livepeer/livepeer.go 55.65217% <100.00000%> (+0.19365%) ⬆️
core/livepeernode.go 74.01575% <ø> (ø)
server/auth.go 63.72549% <ø> (ø)
server/ai_mediaserver.go 7.90514% <0.00000%> (-0.01565%) ⬇️
cmd/livepeer/starter/starter.go 7.51409% <0.00000%> (-0.02360%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe7949...288f07e. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/livepeer.go 55.65217% <100.00000%> (+0.19365%) ⬆️
core/livepeernode.go 74.01575% <ø> (ø)
server/auth.go 63.72549% <ø> (ø)
server/ai_mediaserver.go 7.90514% <0.00000%> (-0.01565%) ⬇️
cmd/livepeer/starter/starter.go 7.51409% <0.00000%> (-0.02360%) ⬇️

... and 1 file with indirect coverage changes

server/auth.go Outdated Show resolved Hide resolved
@gioelecerati gioelecerati force-pushed the gio/gateway/pass-region-to-gateway branch from d5dddfa to 0fbaea1 Compare December 17, 2024 10:16
@gioelecerati gioelecerati marked this pull request as ready for review December 17, 2024 10:18
@gioelecerati gioelecerati changed the title gateway: AIauthWebhook: send additional node info to webhook gateway: ai authWebhook: send gatewayHost to auth webhook Dec 17, 2024
@thomshutt thomshutt merged commit a842a0d into master Dec 17, 2024
18 checks passed
@thomshutt thomshutt deleted the gio/gateway/pass-region-to-gateway branch December 17, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants