-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ai: Update llm pipeline #3336
base: master
Are you sure you want to change the base?
ai: Update llm pipeline #3336
Conversation
I will update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 2 comments. Please also check if CI passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ad-astra-video The PR looks fine, but I see CI is failing, could you check?
https://github.com/livepeer/go-livepeer/actions/runs/12532555474/job/34951389606?pr=3336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but remember to update go.mod before merging
54e8266
to
eaba8ca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3336 +/- ##
===================================================
+ Coverage 33.68997% 33.69713% +0.00716%
===================================================
Files 141 141
Lines 37480 37475 -5
===================================================
+ Hits 12627 12628 +1
+ Misses 24131 24125 -6
Partials 722 722
Continue to review full report in Codecov by Sentry.
|
@rickstaa @kyriediculous Updated PR for latest updates in LLM pipeline. Please let me know if anything want changed. Built and tested locally end-to-end with no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will run one production test and merge.
7d51f5a
to
29a291f
Compare
fc3530e
to
0b9cdc7
Compare
What does this pull request do? Explain your changes. (required)
Updates go-livepeer for LLM pipeline updates for new response format.
Adds in validation of LLM request to gateway provided in #3204
Note: checked box to allow edits by maintainers to help expedite with timezone difference. Feel free to push any updates needed to branch.
Requires ai-worker livepeer/ai-worker#387 to be merged
Specific updates (required)
How did you test each of these updates (required)
Built docker image locally for
livepeer/ai-runner:llm
andlivepeer/go-livepeer
to test streaming and non-streaming responsesDoes this pull request close any open issues?
No
Checklist:
make
runs successfully./test.sh
pass