-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-2342] ai_first_segment_delay metric added #3341
[ENG-2342] ai_first_segment_delay metric added #3341
Conversation
139f2c8
to
c8cbe79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3341 +/- ##
===================================================
- Coverage 33.72469% 33.72276% -0.00193%
===================================================
Files 141 141
Lines 37391 37405 +14
===================================================
+ Hits 12610 12614 +4
- Misses 24061 24070 +9
- Partials 720 721 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
monitor/census.go
Outdated
@@ -1987,6 +1996,10 @@ func AIResultDownloaded(ctx context.Context, pipeline string, model string, down | |||
} | |||
} | |||
|
|||
func AIFirstSegmentDelay(delay int64) { | |||
stats.Record(census.ctx, census.mAIFirstSegmentDelay.M(delay)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we may want to tag it with Orchestrator's address?
I can imagine that for the given Gateway, only some Os may be slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That would be interesting information.
The question is how to get Orchestrator info in startTrickleSubscribe()
function.
Where of if does it live on the Gateway code? We'd need OrchestratorInfo
struct, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can pass host to startTrickleSubscribe()
.
This host
is good as a tag. It's the IP/DNS of the Orchestrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I took entire orchInfo and unified it a bit on the census-side
3b333a6
to
de6fb68
Compare
de6fb68
to
6a33ba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one more comment on how to tag with host
6a33ba2
to
33cf5a6
Compare
33cf5a6
to
ee71e3b
Compare
eeaf6f8
to
9e290c1
Compare
9e290c1
to
ef06672
Compare
Adding
ai_first_segment_delay
prometheus metric.It measures the time between AI Gateway receiving a GenLiveVideoToVideo request and successfully receiving the first processed segment from O.