This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is:
When a client triggers EOF in server to close connection (in Ruby client
ftp.close
) the server doesn't handle this signal and forces the client to wait on read.To be:
When EOF is received, close the socket immediately.
How to reproduce:
Another run on this branch:
This is where the 3s of wait comes from https://github.com/ruby/ruby/blob/ruby_2_6/lib/net/ftp.rb#L1308
Furthermore, I suspect that this is the reason why integration and functional tests are disabled by default in this project. With this fix, the execution time shrinks significantly - from
Finished in 21.24 seconds (files took 0.14215 seconds to load)
toFinished in 0.21783 seconds (files took 0.14647 seconds to load)