Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky/wheel dl issues #39

Merged

Conversation

stickykeys99
Copy link
Contributor

Issue #36:
The name of the model wheels do not comply to newer PEP.

Fix:
PRs to the corresponding models on huggingface are published.
Hardcoded URLs to these wheels (on this repo) are edited correspondingly.

--
Issue #37:
The package spacy-transformers is not automatically installed when installing the package, nor after downloading the models.

Fix:
Added spacy-transformers to pyproject.toml of calamanCy.

--
Issue #38:
UserWarnings due to updates in spacy-transformers package.

Fix:
This can be fixed if the models are updated to match specifications of newer versions of transformers. However, since I do not manage these models, I simply restricted the version of spacy-transformers to >=1.2.5,<1.3.0.

--
Thanks. Let me know if this is helpful or if there are issues.

@ljvmiranda921
Copy link
Owner

Hi @stickykeys99 , thanks for the PR! While you're here, can you also update this line: https://github.com/ljvmiranda921/calamanCy/blob/master/.github/workflows/test.yml#L67 to use the correct _md model? Just so the tests pass.

@stickykeys99
Copy link
Contributor Author

Hi, it may work now

@ljvmiranda921
Copy link
Owner

Thank you! Merging this in a few :)

@ljvmiranda921 ljvmiranda921 merged commit e8682d0 into ljvmiranda921:master Aug 2, 2024
7 checks passed
@ljvmiranda921
Copy link
Owner

I'll make a new release in PyPI this weekend, in the meantime, you can always clone and install from master :) Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants