Croatian lang support #1468
Merged
Croatian lang support #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to add attribute |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1468 +/- ##
==========================================
+ Coverage 99.11% 99.26% +0.14%
==========================================
Files 58 58
Lines 2041 2041
==========================================
+ Hits 2023 2026 +3
+ Misses 18 15 -3 |
lk-geimfari
reviewed
Jan 18, 2024
There was a problem hiding this comment.
This file is too big. I think it make sence to reduce the volume of data in this file.
There was a problem hiding this comment.
The size of this file should ideally not exceed 500-600 kilobytes; otherwise, the final size of the mimesis package will be too large, and it may become a problem to install it for people with a slow internet connection.
lk-geimfari
added a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
Related issues
#1467