Skip to content

Commit

Permalink
[FxImporter] remove weakref finalizer of reftracker
Browse files Browse the repository at this point in the history
Signed-off-by: Ege Beysel <[email protected]>
  • Loading branch information
egebeysel committed Feb 7, 2025
1 parent 1690320 commit 2d3053b
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions python/torch_mlir/extras/fx_importer.py
Original file line number Diff line number Diff line change
Expand Up @@ -2247,14 +2247,15 @@ def track(self, referrent: Any) -> RefMapping:
if existing:
return existing
info = RefMapping(referrent)
if referrent is not Empty:
weakref.finalize(referrent, self._ref_finalizer, ref_id)
# Finalizer is removed due to a memory leak
# See: https://github.com/iree-org/iree-turbine/issues/281
# if referrent is not Empty:
# weakref.finalize(referrent, self._ref_finalizer, ref_id)
self._refs[ref_id] = info
return info

def _ref_finalizer(self, ref_id: int):
del self._refs[ref_id]


# def _ref_finalizer(self, ref_id: int):
# del self._refs[ref_id]

################################################################################
# Mappings
Expand Down

0 comments on commit 2d3053b

Please sign in to comment.