Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-80 Feat: Implement Container component #130

Merged
merged 2 commits into from
Feb 10, 2022
Merged

DS-80 Feat: Implement Container component #130

merged 2 commits into from
Feb 10, 2022

Conversation

crishpeen
Copy link
Member

…web and showcase them in demo

@crishpeen crishpeen added the feature New feature or request label Jan 25, 2022
@crishpeen crishpeen requested review from literat, adamkudrna and a team January 25, 2022 12:26
@crishpeen crishpeen self-assigned this Jan 25, 2022
@crishpeen crishpeen force-pushed the feature/DS-80 branch 3 times, most recently from e7697e2 to 367f072 Compare January 25, 2022 21:18
literat
literat reviewed Jan 31, 2022
View reviewed changes
.stylelintrc Outdated Show resolved Hide resolved
@literat literat mentioned this pull request Feb 1, 2022
Open
@literat
Copy link
Collaborator

literat commented Feb 1, 2022

Please, resolve conflict in .stylelintrc.

adamkudrna
adamkudrna requested changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move Grid changes to a separate PR as discussed over Slack. It will make this PR smaller and easier to review.

examples/web/jobs.html Outdated Show resolved Hide resolved
packages/design-tokens/src/scss/_breakpoints.scss Outdated Show resolved Hide resolved
packages/web/src/components/Container/_Container.scss Outdated Show resolved Hide resolved
packages/web/src/components/Container/_theme.scss Outdated Show resolved Hide resolved
packages/web/src/components/Container/_theme.scss Outdated Show resolved Hide resolved
packages/design-tokens/src/scss/index.scss Show resolved Hide resolved
packages/web/src/components/Container/README.md Outdated Show resolved Hide resolved
packages/web/src/components/Container/_tools.scss Show resolved Hide resolved
packages/web/src/components/Grid/README.md Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the feature/DS-80 branch 2 times, most recently from 2d55cd7 to b1820de Compare February 10, 2022 10:08
@crishpeen crishpeen changed the title DS-80 Feat: Implement Container and simple Grid components to spirit-… DS-80 Feat: Implement Container component Feb 10, 2022
adamkudrna
adamkudrna approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍🏻

@crishpeen crishpeen merged commit 81ee920 into main Feb 10, 2022
@crishpeen crishpeen deleted the feature/DS-80 branch February 10, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat left review comments

@adamkudrna adamkudrna adamkudrna approved these changes

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crishpeen @literat @adamkudrna