Skip to content

Commit

Permalink
Remove generate target from build/test targets (ray-project#1874)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewsykim authored Jan 29, 2024
1 parent 2a9e647 commit e2e4208
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions ray-operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ help: ## Display this help.
manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=kuberay-operator webhook paths="./..." output:crd:artifacts:config=config/crd/bases

generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, DeepCopyObject methods and generated client for ApplyConfiguration.
generate: manifests api-docs controller-gen ## Generate code containing DeepCopy, DeepCopyInto, DeepCopyObject methods and generated client for ApplyConfiguration.
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."
./hack/update-codegen.sh

Expand All @@ -64,20 +64,20 @@ fumpt: gofumpt

test: WHAT ?= $(shell go list ./... | grep -v /test/)
test: ENVTEST_K8S_VERSION ?= 1.24.2
test: manifests generate fmt vet envtest ## Run tests.
test: manifests fmt vet envtest ## Run tests.
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $(WHAT) -coverprofile cover.out

# You can use `go test -timeout 30m -v ./test/e2e/rayjob_test.go ./test/e2e/support.go` if you only want to run tests in `rayjob_test.go`.
test-e2e: WHAT ?= ./test/e2e
test-e2e: manifests generate fmt vet ## Run e2e tests.
test-e2e: manifests fmt vet ## Run e2e tests.
go test -timeout 30m -v $(WHAT)

sync: helm api-docs
./hack/update-codegen.sh

##@ Build

build: generate fmt vet ## Build manager binary.
build: fmt vet ## Build manager binary.
go build \
-ldflags \
" \
Expand All @@ -86,7 +86,7 @@ build: generate fmt vet ## Build manager binary.
" \
-o bin/manager main.go

# run: manifests generate fmt vet
# run: manifests fmt vet
# Running the controller from your host may fail to reconcile resources. For example, when creating a RayService
# KubeRay sends HTTP requests to the Ray head using ${HEAD_SVC_FQDN}:52365 which is not reachable from outside of a K8s cluster.
# For detail, see https://docs.ray.io/en/master/cluster/kubernetes/troubleshooting/rayservice-troubleshooting.html#issue-5-fail-to-create-update-serve-applications
Expand Down

0 comments on commit e2e4208

Please sign in to comment.