-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-misc/homeassistant-bin #2
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR @rdnetto The systemd unit and KEYWORDS changes both LGTM I think the write bit change will break various ways homeassistant configures itself (which it persists itself to files in /etc/homeassistant) and e.g. things like the automation editor (https://www.home-assistant.io/docs/automation/editor/). It would be good to lock down these config files somehow, but I am not sure there is anyway around this? At a later stage it might be nice to add systemctl stop/start or restart support to the included update-homeassistant script (installed from the filesdir) - just for consistency, but there is no requirement to use it. I will also copy to the systemd unit file to the work-in-progress non-bin app-misc/homeassistent ebuild when I get back to it (to keep them in somewhat in sync). |
Type=simple | ||
User=homeassistant | ||
ExecStart=/opt/homeassistant/bin/hass --log-file /var/log/homeassistant/homeassistant.log $HASS_OPTS | ||
EnvironmentFile=/etc/conf.d/homeassistant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably split this configuration file from the openrc one as well (see: https://wiki.gentoo.org/wiki/Project:Systemd/conf.d_files)
For the 0.68.0 version bump, I:
I don't think any of the above should break running under systemd - let me know if did however... Still todo:
|
This PR makes the following changes to the
homeassistant-bin
ebuild:9999
version - since installing this means that portage won't automatically update homeassistant to later versions, users should have to opt-in to it by explicitly unkeywording it.