Strict Validation b089df5 #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a dirty hack, cakephp will wrap each checkbox in a div, and set the lables after the input bootstrap wants the checkbox wrapped in a label, and the text afterward
including basic text, textareas, selects including radio, inline checkboxes, multiple checkboxes (vertical) including append/prepend (text and buttons) @todo: include mockups for success / error messages (validation)
…elper Conflicts: View/Helper/TwitterBootstrapHelper.php
If you use Form->create('Model') and then add TwitterBootstrap->input('fieldname')
the verification steps to check for errors don't work... namely $this->error()
This is because the defaultModel property is set on the Form helper, not the TwitterBootstrap instance of the Form helper
There is no clean and easy way to get it out of the other helper instance.. so intstead we allow them to create the form through this helper instance (which extends the FormHelper anyway and as such, means it's really, really simple/easy)
(note: this will tie in with a forthcoming commit to add some skel files for view bakind with TwitterBootstap form inputs)
The method add_crumb() does not follow cakphp convention and as such is confusing for people who want to be able to add crumbs and realize they can not with the HtmlHelper, but instead need to do so with with TwitterBootstrapHelper... No change was made to the add_crumb() method, so it remains backwards compatible
I took a few liberties and created a couple of elements to facilitate breadcrumbs and pagination... as this is how I usually have implemented it in the past and it's simpler than across several views... but if you frown on this solution (which I can understand) please feel free to recreate/rewite as you see fit We might want to implement a better HABTM checkbox input setup... Also, I am wondering if we want to add any extra blank options to form inputs, to facilitate their use?
…so we can pre-check radio buttons
|
Just wanted to let you know we're aware of your pull request. Personally I like a lot of what you've done and wish it had been in the Helper a while ago. In any case, please don't take our tardiness in responding or merging as an insult-- we're just pretty busy. |
…sable HTML escaping validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you may only want to cherry pick b089df5