MPA Session Calculation #1651
Merged
MPA Session Calculation #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetti-squash
previously approved these changes
Oct 15, 2023
| @@ -160,5 +164,5 @@ export function barfOutfit(spec: OutfitSpec = {}, sim = false): Outfit { | |||
| parka: "kachungasaur", | |||
| }); | |||
|
|
|||
| return outfit; | |||
| return { outfit, extraValue }; | |||
There was a problem hiding this comment.
I don't love doing this for barf and nothing else, seems counterintuitive & inconsistent. But I get it
Might be worth exporting two functions, like the freeFightFamiliarData and freeFightFamiliar thing?
|
|
||
| return { | ||
| familiar: best.familiar, | ||
| extraValue: extraValue(best, meatFamiliarEntry, jellyfish), |
There was a problem hiding this comment.
I think I need some documentation about what extraValue means here. extra compared to what?
spaghetti-squash
previously approved these changes
Oct 25, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
* MPA Session Calculation * Attempt to readd marginal familiar extra value tracking * Formatting & Fixes --------- Co-authored-by: neil <[email protected]> Co-authored-by: horrible little slime <[email protected]>
spaghetti-squash
added a commit
that referenced
this pull request
Mar 5, 2024
This reverts commit d06c19e.
spaghetti-squash
added a commit
that referenced
this pull request
Mar 5, 2024
|
Had to revert, this is a breaking change because of a circular bit of logic between barfFamiliar and barfOutfit. I don't think we can capture the excess familiar value with that level of precision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.