Cockroach copy target #2070
Cockroach copy target #2070
Conversation
* Push some improvements and fixes to make this more accessible. * Update packages/garbo/src/tasks/cockroachPrep.ts Co-authored-by: neil <[email protected]> * Fix the overcapstat element * Add bonuses for fun equipment and carnplant * Do effect removal first, shruggable first * Genericize our debuff picker * Add some breaks * Fix the debuff item logic and other small things * Use the pref for clipper unlocked rather than the proxy of storm runs * Move final cockroach fight to later to benefit from buffs * Update packages/garbo/src/index.ts Co-authored-by: neil <[email protected]> * Filter debuff items down to potions * Optimize Giant Giant crab, further limit debuff scope to buyable or have() * 100 stat is fine; > 100 isn't * Avoid certain debuff items * fix the avoid bad debuff function, add avoid candelabara * refactor --------- Co-authored-by: neil <[email protected]> Co-authored-by: horrible little slime <[email protected]>
|
What else does this need to move to live? Anything we're waiting on? |
We can just check here to see which comments/reviews are still active: https://github.com/loathers/garbage-collector/pull/2070/files Also, I'm unsure about having two |
|
Works great! Been running it for two? Three? months that way |
* refactor debuffing into a planner class * make things that don't need to be methods into functions * mild restructure, reveal price * abort on execution failure * whoops * various fixes to the debuffplanner * more small streamlining
There was a problem hiding this comment.
Issue still to address as of 25th Feb - Visit Port Beginning to make sure the PR properties are up to date.
The properties these changes rely on such as pirateRealmUnlockedAnemometer will not be set for most people as they were only added to mafia in the last year, long after most people will have run Pirate Realm.
Visiting Port Beginning only requires wearing the Piraterealm Eyepatch so rolling through the initial setup in ambiguous situations should be a cost-free endeavour.
|
Also @Shiverwarp wanted to add a price cap/check for debuffing, which is possible now with the new |
One tricky thing here is that we theoretically want to do that before assigning the |
Why does it feel wrong? Otherwise decisions are being made with incomplete information unnecessarily. It costs us nothing but a handful of server hits to ensure our properties are up to date and even then it's only necessary for users who have PR access but the properties we care about are still set to their default values. |
Just trying to block out the structure a bit in this draft