Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setuptools_scm #5

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use setuptools_scm #5

wants to merge 2 commits into from

Conversation

giograno
Copy link
Member

@giograno giograno commented Oct 18, 2024 •
edited
Loading

This PR introduces setuptools_scm to compute versions for the handcrafted SDK.

We don't use setuptools_scm directly in the generated code (that would require changing the pyproject.toml mustache template; the version parameter is also used in the generated code) but we inject the right version with the following command uvx --from setuptools-scm python -m setuptools_scm.

@giograno giograno requested a review from silv-io October 18, 2024 22:52
@giograno giograno marked this pull request as ready for review October 18, 2024 22:59
@giograno giograno marked this pull request as draft October 24, 2024 01:02
@giograno
Copy link
Member Author

giograno commented Nov 5, 2024

The way uv uses its lock files is a problem when using dynamic versioning (see more context here). Waiting for some workaround before moving forwards with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io Awaiting requested review from silv-io

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@giograno