Fix predicates for MultiPoint with EMPTY

locationtech · Nov 8, 2023 · af4eae4 · af4eae4
1 parent 89309b2
commit af4eae4
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 1 deletion.
diff --git a/modules/core/src/main/java/org/locationtech/jts/algorithm/PointLocator.java b/modules/core/src/main/java/org/locationtech/jts/algorithm/PointLocator.java
@@ -107,6 +107,9 @@ else if (geom instanceof Polygon) {
 
   private void computeLocation(Coordinate p, Geometry geom)
   {
+    if (geom.isEmpty())
+      return;
+
     if (geom instanceof Point) {
       updateLocationInfo(locateOnPoint(p, (Point) geom));
     }

diff --git a/modules/core/src/main/java/org/locationtech/jts/geomgraph/GeometryGraph.java b/modules/core/src/main/java/org/locationtech/jts/geomgraph/GeometryGraph.java
@@ -222,7 +222,9 @@ private void addCollection(GeometryCollection gc)
   {
     for (int i = 0; i < gc.getNumGeometries(); i++) {
       Geometry g = gc.getGeometryN(i);
-      add(g);
+      if (! g.isEmpty()) {
+        add(g);
+      }
     }
   }
   /**

diff --git a/modules/core/src/test/java/org/locationtech/jts/operation/relate/RelateTest.java b/modules/core/src/test/java/org/locationtech/jts/operation/relate/RelateTest.java
@@ -101,6 +101,12 @@ public void testIntersectsSnappedEndpoint2()
     runRelateTest(a, b,  "FF10F0102"  );
   }
 
+  public void testMultiPointWithEmpty()
+  {
+    String a = "MULTIPOINT(EMPTY,(0 0))";
+    String b = "POLYGON ((1 0,0 1,-1 0,0 -1, 1 0))";
+    runRelateTest(a, b,  "0FFFFF212"  );
+  }
 
   void runRelateTest(String wkt1, String wkt2, String expectedIM)
   {

diff --git a/modules/tests/src/test/resources/testxml/general/TestRelatePA.xml b/modules/tests/src/test/resources/testxml/general/TestRelatePA.xml
@@ -100,4 +100,29 @@
 </test>
 </case>
 
+<case>
+  <desc>mPA - empty Point element</desc>
+  <a>
+    MULTIPOINT(EMPTY,(0 0))
+  </a>
+  <b>
+    POLYGON ((1 0,0 1,-1 0,0 -1, 1 0))
+  </b>
+<test>
+  <op name="relate" arg3="0FFFFF212" arg1="A" arg2="B">
+    true
+  </op>
+</test>
+<test><op name="contains"   arg1="A" arg2="B"> false </op></test>
+<test><op name="coveredBy"  arg1="A" arg2="B"> true  </op></test>
+<test><op name="covers"     arg1="A" arg2="B"> false </op></test>
+<test><op name="crosses"    arg1="A" arg2="B"> false </op></test>
+<test><op name="disjoint"   arg1="A" arg2="B"> false </op></test>
+<test><op name="equalsTopo" arg1="A" arg2="B"> false </op></test>
+<test><op name="intersects" arg1="A" arg2="B"> true  </op></test>
+<test><op name="overlaps"   arg1="A" arg2="B"> false </op></test>
+<test><op name="touches"    arg1="A" arg2="B"> false </op></test>
+<test><op name="within"     arg1="A" arg2="B"> true  </op></test>
+</case>
+
 </run>
-Original file line number
+Diff line change
@@ Expand Up / @@ -222,7 +222,9 @@ private void addCollection(GeometryCollection gc) @@
       {
         for (int i = 0; i < gc.getNumGeometries(); i++) {
           Geometry g = gc.getGeometryN(i);
-          add(g);
+          if (! g.isEmpty()) {
+            add(g);
+          }
         }
       }
       /**
@@ Expand Down @@