Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): enabling data use terms column in the search view #3604

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Feb 3, 2025

resolves #3600

bug introduced here: #3322

I wanted to initially have the data use terms show by default when bulk editing is enabled, but accidentally I didn't just do it "initially", but it became completely synced.

In this fix the code was now moved into a useEffect so it only is ran once when the component is initialized.

preview URL: https://dut-bug-fix.loculus.org/

What I tested

  • enabling/disabling the column in search works
  • the column is still by default shown in the 'Submit' > [organism] > 'View'

Screenshot/Recording

Screen.Recording.2025-02-03.at.11.31.16.mov

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fhennig fhennig changed the title fix(website): .... fix(website): enabling data use terms column in the search view Feb 3, 2025
@fhennig fhennig self-assigned this Feb 3, 2025
@fhennig fhennig added the preview Triggers a deployment to argocd label Feb 3, 2025
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theosanderson
Copy link
Member

theosanderson commented Feb 3, 2025

(If you go to the bulk-view-submissions page, then turn off the data use terms display, then refresh then it reappears - but that's incredibly minor and unlikely to happen)

@fhennig fhennig merged commit b5a6418 into main Feb 3, 2025
20 checks passed
@fhennig fhennig deleted the dut-bug-fix branch February 3, 2025 10:47
@fhennig
Copy link
Contributor Author

fhennig commented Feb 3, 2025

Ah yes true. I now briefly looked into how to instead pass that in the URLSearchParams but yeah not worth the effort ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to display 'data use terms' column when customising columns
2 participants