Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prompt for missing vcluster name in create command #2216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: prompt for missing vcluster name in create command #2216

wants to merge 1 commit into from

Conversation

zerbitx
Copy link
Contributor

@zerbitx zerbitx commented Oct 9, 2024 •
edited
Loading

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

resolves #ENG-4851

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e637f1
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/67090d1942a96c00088ecc57

@zerbitx zerbitx marked this pull request as draft October 9, 2024 19:50
@zerbitx zerbitx force-pushed the ENG-4851 branch 2 times, most recently from 8ba514e to bca0d36 Compare October 9, 2024 20:01
@zerbitx zerbitx marked this pull request as ready for review October 9, 2024 22:46
@zerbitx zerbitx requested a review from a team October 10, 2024 01:16
FabianKramm
FabianKramm requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@zerbitx zerbitx force-pushed the ENG-4851 branch 2 times, most recently from 626c33b to 28cfd19 Compare October 10, 2024 13:19
@zerbitx zerbitx marked this pull request as draft October 10, 2024 13:23
@zerbitx zerbitx force-pushed the ENG-4851 branch 7 times, most recently from a7a0db5 to a1af21d Compare October 10, 2024 22:22
@zerbitx zerbitx marked this pull request as ready for review October 10, 2024 22:56
@zerbitx
Copy link
Contributor Author

zerbitx commented Oct 11, 2024

I also noticed warnings in CI about --distro being deprecated, so I made a few changes to add the distro to the values yaml's for the distro.

FabianKramm
FabianKramm requested changes Oct 11, 2024
View reviewed changes
pkg/cli/util/args.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasK33 ThomasK33 ThomasK33 approved these changes

@FabianKramm FabianKramm FabianKramm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerbitx @ThomasK33 @FabianKramm