-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s dependencies to 1.32 #2427
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vcluster-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
1efaf93
to
0ad0fe1
Compare
There are two more tests which are failing. These tests were recently added in conformance test suite (a couple of months back). Below are the tests and the RCA:
Why are these tests failing? These tests perform the lifecycle operations (CRUD) for nodes and CSI nodes on vcluster respectively but since vcluster doesn't inherently support the node creation on the virtual cluster, so Probable Solutions: Since this is a case of a feature not supported so ideally it should be skipped but that might impact the certification failure as mentioned in conformance test instructions.
Let me know your opinions and based on that I will create the PR to fix these remaining 2 conformance tests. |
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind feature
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves ENG-5389
ENG-5387
Please provide a short message that should be published in the vcluster release notes
Updated vcluster Kubernetes dependencies to v1.32
What else do we need to know?
This PR also fixes vcluster for failing conformance tests because of following issues:
status.qosClass
has been made immutable from k8s version 1.32 as done over here. When there is a mismatch instatus.qosClass
field in vcluster and host cluster and vlcuster tries to patch the field in vcluster, the patch fails with an error. This causes conformance tests to fail. The PR fixes tests by ignoring this field in the pod syncer patch updates.Job should allow to use a pod failure policy to ignore failure matching on DisruptionTarget condition [Conformance]
was failing because the job controller on vcluster expected the pod to be infailed
state before deleting it.In this case when the host pod is marked for deletion, the host pod gets into
Failed
state. But these status updates were not getting propogated to vcluster pod. This led to vcluster pod to be dangling state which caused the test failure. The PR adds a fix of propogating the status updates of host pod to vcluster pod when the host pod is marked for deletion.