Cache compatibility fix #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to access it.\nThis should improve compatibility with various other middleware, such as caches, that may not always pass a response on with a context_data attribute. There should be no bad side-effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to make sure response has a context_data attribute before trying to access it.
This should improve compatibility with various other middleware, such as caches, that may not always pass a response on with a context_data attribute. There should be no bad side-effects.
Originally reported over on the Wagtail-Cache repo here: coderedcorp/wagtail-cache#5
This PR makes the two packages work nicely together.