-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly name netty threads #511
Conversation
bossGroup = new NioEventLoopGroup(eventLoopThreadCount); // TODO: add a config to make it adjustable, no need many threads | ||
workGroup = new NioEventLoopGroup(eventLoopThreadCount); | ||
bossGroup = new NioEventLoopGroup(eventLoopThreadCount, daemonThreadFactory(id + "-bossGroup")); // TODO: add a config to make it adjustable, no need many threads | ||
workGroup = new NioEventLoopGroup(eventLoopThreadCount, daemonThreadFactory(id + "-workGroup")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this is helpful for investigation.
- And we should also do same to http-input: https://github.com/logstash-plugins/logstash-input-http/blob/main/src/main/java/org/logstash/plugins/inputs/http/NettyHttpServer.java#L46C77-L46C102
- set boss group thread 1 by default
I have raised a PR against your target branch to fix test failures: jsvd#1 |
Update the Java unit tests which use the interface changed Server class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Self note: I think backporting this change to 6.x will be also good (as 8.x stays for years...). I will backport. |
Co-authored-by: Mashhur <[email protected]>
Co-authored-by: Mashhur <[email protected]>
Example with:
bin/logstash -e "input { beats { id => my_beats port => 3333 } }" -w 1
Before
After