Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogtailHandler: implement logging.Handler.flush #26

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

PetrHeinz
Copy link
Member

Implementing flush method on our handler.

The method should be implemented by subclasses of logging.Handler. It's called automatically during graceful termination.
https://github.com/python/cpython/blob/8e8a4baf652f6e1cee7acde9d78c4b6154539748/Lib/logging/__init__.py#L1039-L1046

The method will enforce uploading the current buffer to Better Stack sooner than in flush_interval, and will wait until all data are sent to Better Stack.


Making check_interval configurable and decreasing the default value from 1s to 100ms, as it may have serious impact on short-running code (example project took ~1.3s to finish before this PR, now takes ~350ms).


It is now safe to terminate execution immediately (eg. using os._exit), if flush() is called before:

for handler in logger.handlers:
    handler.flush()

os._exit(os.EX_OK)

@PetrHeinz PetrHeinz requested a review from curusarn June 19, 2024 11:31
@PetrHeinz
Copy link
Member Author

Seems that the 3.11 tests fail on master as well: https://github.com/logtail/logtail-python/actions/runs/9581314199/job/26417818292

Copy link
Contributor

@curusarn curusarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@PetrHeinz PetrHeinz merged commit 51e2c2f into master Jun 19, 2024
10 checks passed
@PetrHeinz PetrHeinz deleted the ph/flush branch June 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants