refactor(core): refactor GET saml app metadata endpoint #6938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/saml-applications/SamlApplication/index.ts | 📉 -31 Bytes |
| packages/core/src/saml-applications/libraries/saml-applications.ts | 📉 -1.13 KB |
| packages/core/src/saml-applications/routes/anonymous.ts | 📉 -18 Bytes |
darcyYe
force-pushed
the
yemq-refactor-get-saml-app-metadata-endpoint
branch
from
4659abf to
284980d
Compare
wangsijie
approved these changes
Jan 14, 2025
wangsijie
pushed a commit
that referenced
this pull request
Jan 24, 2025
* refactor(core): refactor GET saml app metadata endpoint * refactor: refactor SamlApplication class to validate only necessary fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactor GET saml app metadata endpoint, reuse SamlApplication class instead of using seprated methods to keep accordance. (resolves LOG-10699)
Previously we check all config attributes when construct the SamlApplication class, but in fact, we should only check those attributes when needed. E.g. when constructing IdP, we do not need to check the config of
acsUrl, we hence update the implementation as well to fix this.Testing
Should be covered by existing integration tests.
Checklist
.changeset