fix: fix SAML app attribute mapping not working issue #6978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
wangsijie,
charIeszhao,
xiaoyijun,
gao-sun and
simeng-li
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/AttributeMapping.tsx | 📉 -366 Bytes |
| packages/core/src/saml-application/SamlApplication/index.test.ts | 📉 -40 Bytes |
| packages/core/src/saml-application/SamlApplication/index.ts | 📉 -67 Bytes |
| packages/integration-tests/src/tests/api/application/saml-application.test.ts | 📉 -2 Bytes |
| packages/schemas/src/foundations/jsonb-types/saml-application-configs.ts | 📉 -6 Bytes |
darcyYe
force-pushed
the
yemq-fix-saml-app-attributes
branch
from
60b6000 to
b68b496
Compare
darcyYe
force-pushed
the
yemq-fix-saml-app-attributes
branch
from
b68b496 to
d587705
Compare
charIeszhao
approved these changes
Jan 24, 2025
wangsijie
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix SAML app attribute mapping not working issue (resolves LOG-10729).
Testing
Tested locally, worked fine:
Checklist
.changeset