chore(core): hide oidcClientMetadata of SAML apps when using GET app APIs #6979
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/routes/applications/application.ts | 📈 +465 Bytes |
| packages/integration-tests/src/tests/api/application/saml-application.test.ts | 📈 +480 Bytes |
darcyYe
force-pushed
the
yemq-hide-oidc-client-metadata-for-saml-apps-when-using-get-apps-API
branch
from
b684413 to
c21a2ee
Compare
darcyYe
changed the title
darcyYe
force-pushed
the
yemq-hide-oidc-client-metadata-for-saml-apps-when-using-get-apps-API
branch
from
c21a2ee to
09f1ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hide oidcClientMetadata of SAML apps when using GET app APIs (resolves LOG-10499), affect
GET /applicationsandGET /applications/:idAPIs.Testing
Covered by integration tests.
Checklist
.changeset