Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make report subscription usage to be non-blocking #7103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Mar 5, 2025

Summary

make report subscription usage to be non-blocking, resolves LOG-10880
we only need to trigger this function, and there is no need to wait for the result.

Testing

N/A

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Mar 5, 2025

COMPARE TO master

Total Size Diff 📉 -3 Bytes

Diff by File
Name Diff
packages/core/src/routes/applications/application.ts 📉 -2 Bytes
packages/core/src/routes/sign-in-experience/index.ts 📉 -1 Bytes

@darcyYe darcyYe requested a review from a team March 5, 2025 10:51
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be async?

Copy link
Member

@charIeszhao charIeszhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code update looks good to me. However, I don't think this is "synchronous". The report function is still asynchronous, we just do not await the function return any more.

@darcyYe
Copy link
Contributor Author

darcyYe commented Mar 6, 2025

to be async?

This method itself is asynchronous, but during actual invocation, it is explicitly declared to execute in the manner of synchronous methods. Let me update the PR description to avoid such misunderstandings.

@darcyYe darcyYe changed the title chore: make report subscription usage to be synchronous chore: make report subscription usage to be non-blocking Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants