chore: reuse subscription library cache in quota library to reduce cross region HTTP requests #7109
+32
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oss region HTTP requests
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/libraries/quota.ts | 📈 +137 Bytes |
| packages/core/src/tenants/Libraries.ts | 📈 +150 Bytes |
| packages/core/src/tenants/Tenant.ts | 📈 +50 Bytes |
| packages/core/src/test-utils/tenant.ts | 📈 +25 Bytes |
| packages/core/src/utils/subscription/index.ts | 📈 +177 Bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reuse subscription library cache in quota library to reduce cross region HTTP requests, resolves LOG-10881
Before this change, quota library relies on Logto Cloud service for checking whether some specific resources can be added. On our product environment, these kind of HTTP requests are in cross-region manner (e.g. request server locates in EU from AU/US regions, which are time-consuming). Since we now have subscription data cached in each region, the access to cached subscription data in the same region saves time and without affect existing logics.
Testing
N/A, only code refactor.
Checklist
.changeset